slfan1989 commented on PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#issuecomment-2652502050
@cnauroth @anujmodi2021 I will continue to follow up on the CheckStyle
issues for this PR. If the CheckStyle issues are related to method names or
magic numbers, we will not be fixing them for now. Are there any other concerns
with this PR? If not, we plan to merge it tomorrow. Thank you for your help
with the verification and review!
Examples of CheckStyle issues that will not be fixed for now:
```
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:259:
public void test_040_PositionedReadHugeFile(TestInfo testInfo) throws
Throwable {:15: Name 'test_040_PositionedReadHugeFile' must match pattern
'^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:317:
public void test_050_readHugeFile(TestInfo testInfo) throws Throwable {:15:
Name 'test_050_readHugeFile' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:343:
public void test_060_openAndReadWholeFileBlocks(TestInfo testInfo) throws
Throwable {:15: Name 'test_060_openAndReadWholeFileBlocks' must match pattern
'^[a-z][a-zA-Z0-9]*$'. [MethodName]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:413:
public void test_100_renameHugeFile(TestInfo testInfo) throws Throwable {:15:
Name 'test_100_renameHugeFile' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/integration/ITestAzureHugeFiles.java:441:
public void test_999_deleteHugeFiles(TestInfo testInfo) throws IOException
{:15: Name 'test_999_deleteHugeFiles' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[MethodName]
/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestBlockBlobInputStream.java:514:
assertTrue(elapsedTimeMs < 20, String.format(:34: '20' is a magic number.
[MagicNumber]
./hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/ITestBlockBlobInputStream.java:578:
elapsedTimeMs < 20, String.format(:27: '20' is a magic number.
[MagicNumber]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
