[
https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927336#comment-17927336
]
ASF GitHub Bot commented on HADOOP-19425:
-----------------------------------------
slfan1989 commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1957037016
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AbstractWasbTestBase.java:
##########
@@ -146,31 +147,37 @@ protected Path path(String filepath) throws IOException {
/**
* Return a path bonded to this method name, unique to this fork during
* parallel execution.
+ * @param testInfo Provides information about the currently executing test
method.
+ * This can include details such as the name of the test method, display
name.
* @return a method name unique to (fork, method).
* @throws IOException IO problems
*/
- protected Path methodPath() throws IOException {
- return path(methodName.getMethodName());
+ protected Path methodPath(TestInfo testInfo) throws IOException {
Review Comment:
@steveloughran We have defined a new class `TestName`, in a class that
extends JUnit 5's `BeforeEachCallback`. This method allows us to retrieve the
specific execution name for each test case via the ExtensionContext before each
test is run. This class serves the same purpose as JUnit 4's `TestName`,
eliminating the need to use TestInfo and reducing the amount of code changes.
If there are no objections, I plan to merge this PR on next Monday. My main
focus next week will be upgrading the JUnit tests for modules related to
Hadoop-Common and YARN.
> [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.
> -------------------------------------------------
>
> Key: HADOOP-19425
> URL: https://issues.apache.org/jira/browse/HADOOP-19425
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
