[ 
https://issues.apache.org/jira/browse/HADOOP-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929024#comment-17929024
 ] 

ASF GitHub Bot commented on HADOOP-19464:
-----------------------------------------

shameersss1 commented on code in PR #7410:
URL: https://github.com/apache/hadoop/pull/7410#discussion_r1964858523


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestEMRFSCompatibility.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.s3a;
+
+import org.assertj.core.api.Assertions;
+import org.junit.Test;
+
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.Path;
+
+import static org.apache.hadoop.fs.contract.ContractTestUtils.touch;
+import static org.apache.hadoop.fs.s3a.Constants.S3N_FOLDER_SUFFIX;
+
+/**
+ * This test verifies that the EMRFS or legacy S3N filesystem compatibility 
with
+ * S3A works as expected.
+ */
+public class ITestEMRFSCompatibility extends AbstractS3ATestBase {

Review Comment:
   @steveloughran  - It is a good call out.
   
   >list parent path reports an empty dir
   
   This is already covered
   
   >delete parent dir results in a getFileStatus(parent) => 404, and same for 
marker.
   
   This is not happening right now (even with hadoop-3.4.1)
   





> Skip S3N Folder Marker _$folder$ During File Listing
> ----------------------------------------------------
>
>                 Key: HADOOP-19464
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19464
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 3.5.0
>            Reporter: Syed Shameerur Rahman
>            Assignee: Syed Shameerur Rahman
>            Priority: Major
>              Labels: pull-request-available
>
> After HADOOP-19278 , The S3N folder marker *_$folder$* is not skipped during 
> listing of S3 directories leading to S3A filesystem not able to read data 
> written by legacy Hadoop S3N filesystem and AWS EMR's EMRFS (S3 filesystem) 
> leading to compatibility issues and possible migration risks to S3A 
> filesystem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to