[
https://issues.apache.org/jira/browse/HADOOP-19461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929984#comment-17929984
]
ASF GitHub Bot commented on HADOOP-19461:
-----------------------------------------
pan3793 commented on PR #7406:
URL: https://github.com/apache/hadoop/pull/7406#issuecomment-2680345619
> you means ...
Don't do things that may confuse users.
1) your current PR title "JVM GC Metrics supports Generational ZGC pause
time" makes me think that the current trunk code does not support
"Generational ZGC pause time", it is incorrect, a better title might be "JVM GC
Metrics supports fine-grained metrics for Generational ZGC"
2) a generic metrics name deserves a generic implementation. For example,
both
[micrometer](https://github.com/micrometer-metrics/micrometer/blob/2.0.x/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetrics.java)
(which is used by Spring Boot) and
[Spark](https://spark.apache.org/docs/latest/monitoring.html) classify the
metrics into a few categories, for all common GC algorithms. if this is hard
for you, please make the metrics name accurate, for example,
"ZGCMajorPausesTimeMillis"
> JVM GC Metrics supports Generational ZGC pause time
> ---------------------------------------------------
>
> Key: HADOOP-19461
> URL: https://issues.apache.org/jira/browse/HADOOP-19461
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: chaijunjie
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-19461.JPG, HADOOP-19461.patch
>
>
> See [https://bugs.openjdk.org/browse/JDK-8307059] , The Generational ZGC
> separate the Cycles and Pauses as Minor and Major,like this:
> * Old ZGC: "ZGC Cycles", "ZGC Pauses"
> * Generational ZGC: "ZGC Minor Cycles", "ZGC Minor Pauses", "ZGC Major
> Cycles", "ZGC Major Pauses"
> let us separate it same and give 2 new metric about these, may be better...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
