chaijunjie0101 commented on PR #7406: URL: https://github.com/apache/hadoop/pull/7406#issuecomment-2680369162
> > you means ... > > Don't do things that may confuse users. > > 1. your current PR title "JVM GC Metrics supports Generational ZGC pause time" makes me think that the current trunk code does not support "Generational ZGC pause time", it is incorrect, a better title might be "JVM GC Metrics supports fine-grained metrics for Generational ZGC" > 2. a generic metrics name deserves a generic implementation. For example, both [micrometer](https://github.com/micrometer-metrics/micrometer/blob/2.0.x/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetrics.java) (which is used by Spring Boot) and [Spark](https://spark.apache.org/docs/latest/monitoring.html) classify the JVM GC metrics into a few categories, for all common GC algorithms. if this is hard for you, please make the metrics name accurate, for example, "ZGCMajorPausesTimeMillis" thank you give me these examples, I will try to combine and support all GCs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
