[ 
https://issues.apache.org/jira/browse/HADOOP-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17930306#comment-17930306
 ] 

ASF GitHub Bot commented on HADOOP-16155:
-----------------------------------------

ahmarsuhail closed pull request #3905: HADOOP-16155. S3AInputStream 
read(bytes[]) to not retry on read failure
URL: https://github.com/apache/hadoop/pull/3905




> S3AInputStream read(bytes[]) to not retry on read failure: pass action up
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-16155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16155
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.2.0
>            Reporter: Steve Loughran
>            Assignee: Ahmar Suhail
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The S3AInputStream reacts to read(byte[]) failure by reopening the stream, 
> just as for the single byte read(). We shouldn't need to do that. Instead 
> just close the stream, return 0 and let the caller decided what to do. 
> why so? 
> # its in the contract of InputStream.read(bytes[]),
> # readFully() can handle the 0 in its loop
> # other apps can decided what to do.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to