ahmarsuhail commented on PR #7334:
URL: https://github.com/apache/hadoop/pull/7334#issuecomment-2682848679
@steveloughran addressed most of your comments, will just double check
everything tomorrow morning and let you know once it's ready for another
review.
`ITestS3AContractVectoredRead.testVectoredReadWholeFilePlusOne` will fail as
by default `fs.contract.vector-io-early-eof-check` is true. I set them to
`conf.set("fs.contract.vector-io-early-eof-check", "false");` in the new
`ITestS3AContractAnalyticsStreamVectoredRead` and they pass.
used `getContract().getConf()` for the conf in the contract tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
