steveloughran commented on code in PR #7433:
URL: https://github.com/apache/hadoop/pull/7433#discussion_r1973722346
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -636,7 +636,8 @@ public void initialize(URI name, Configuration originalConf)
// If encryption method is set to CSE-KMS or CSE-CUSTOM then CSE is
enabled.
isCSEEnabled =
CSEUtils.isCSEEnabled(getS3EncryptionAlgorithm().getMethod());
- isAnalyticsAccelaratorEnabled =
StreamIntegration.determineInputStreamType(conf).equals(InputStreamType.Analytics);
+ isAnalyticsAccelaratorEnabled =
StreamIntegration.determineInputStreamType(conf)
Review Comment:
nit: spelling
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AAnalyticsAcceleratorStreamReading.java:
##########
@@ -141,37 +144,37 @@ public void testMalformedParquetFooter() throws
IOException {
* can contain multiple row groups, this allows for further parallelisation,
as each row group
* can be processed independently.
*/
- @Test
- public void testMultiRowGroupParquet() throws Throwable {
+ @Test
+ public void testMultiRowGroupParquet() throws Throwable {
describe("A parquet file is read successfully");
Path dest = path("multi_row_group.parquet");
- File file = new File("src/test/resources/multi_row_group.parquet");
- Path sourcePath = new Path(file.toURI().getPath());
- getFileSystem().copyFromLocalFile(false, true, sourcePath, dest);
+ File file = new File("src/test/resources/multi_row_group.parquet");
+ Path sourcePath = new Path(file.toURI().getPath());
+ getFileSystem().copyFromLocalFile(false, true, sourcePath, dest);
- FileStatus fileStatus = getFileSystem().getFileStatus(dest);
+ FileStatus fileStatus = getFileSystem().getFileStatus(dest);
- byte[] buffer = new byte[3000];
- IOStatistics ioStats;
+ byte[] buffer = new byte[3000];
+ IOStatistics ioStats;
- try (FSDataInputStream inputStream = getFileSystem().open(dest)) {
- ioStats = inputStream.getIOStatistics();
- inputStream.readFully(buffer, 0, (int) fileStatus.getLen());
- }
+ try (FSDataInputStream inputStream = getFileSystem().open(dest)) {
+ ioStats = inputStream.getIOStatistics();
+ inputStream.readFully(buffer, 0, (int) fileStatus.getLen());
+ }
- verifyStatisticCounterValue(ioStats, STREAM_READ_ANALYTICS_OPENED, 1);
+ verifyStatisticCounterValue(ioStats, STREAM_READ_ANALYTICS_OPENED, 1);
- try (FSDataInputStream inputStream = getFileSystem().openFile(dest)
-
.must(FS_OPTION_OPENFILE_READ_POLICY,FS_OPTION_OPENFILE_READ_POLICY_PARQUET)
- .build().get()) {
- ioStats = inputStream.getIOStatistics();
- inputStream.readFully(buffer, 0, (int) fileStatus.getLen());
- }
+ try (FSDataInputStream inputStream = getFileSystem().openFile(dest)
+ .must(FS_OPTION_OPENFILE_READ_POLICY,
FS_OPTION_OPENFILE_READ_POLICY_PARQUET)
+ .build().get()) {
+ ioStats = inputStream.getIOStatistics();
+ inputStream.readFully(buffer, 0, (int) fileStatus.getLen());
+ }
- verifyStatisticCounterValue(ioStats, STREAM_READ_ANALYTICS_OPENED, 1);
- }
+ verifyStatisticCounterValue(ioStats, STREAM_READ_ANALYTICS_OPENED, 1);
Review Comment:
add a check for the filesystem iostats too, to make sure it trickles up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
