cnauroth commented on code in PR #7437:
URL: https://github.com/apache/hadoop/pull/7437#discussion_r1974178628
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/cache/TestFederationCache.java:
##########
@@ -63,15 +60,16 @@ public static Collection<Class[]> getParameters() {
private FederationStateStoreTestUtil stateStoreTestUtil;
private FederationStateStoreFacade facade;
- public TestFederationCache(Class cacheClassName) {
+ public void initTestFederationCache(Class cacheClassName)
Review Comment:
Can this be made `private`?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZKFederationStateStoreOpDurations.java:
##########
@@ -236,4 +237,9 @@ public void removeStoredTokenDuration(long startTime, long
endTime) {
public void getTokenByRouterStoreTokenDuration(long startTime, long endTime)
{
getTokenByRouterStoreToken.add(endTime - startTime);
}
+
+ @VisibleForTesting
+ protected ZKFederationStateStoreOpDurations resetOpDurations() {
Review Comment:
I think I understand why the `resetOpDurations` changes were made. (There's
a singleton instance holding state across test cases.) However, did something
about JUnit 5 trigger the need for this? Is it just an unrelated bug?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java:
##########
@@ -84,16 +81,17 @@ public static Collection<Boolean[]> getParameters() {
private Boolean isCachingEnabled;
- public TestFederationStateStoreFacade(Boolean isCachingEnabled) {
+ public void initTestFederationStateStoreFacade(Boolean pIsCachingEnabled)
Review Comment:
Can this be made `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
