cnauroth commented on code in PR #7390:
URL: https://github.com/apache/hadoop/pull/7390#discussion_r1974197651
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java:
##########
@@ -183,20 +182,19 @@ public class TestDockerContainerRuntime {
private final static String ENV_OCI_CONTAINER_RUN_PRIVILEGED_CONTAINER =
formatOciEnvKey(RUNTIME_TYPE, RUN_PRIVILEGED_CONTAINER_SUFFIX);
- @Rule
- public TemporaryFolder tempDir = new TemporaryFolder();
-
- @Parameterized.Parameters(name = "https={0}")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] {
{true}, {false}
});
}
- @Parameterized.Parameter
public boolean https;
- @Before
+ public void initHttps(boolean pHttps) {
Review Comment:
Can this be made `private`?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestRuncContainerRuntime.java:
##########
@@ -160,10 +163,14 @@ public static Collection<Object[]> data() {
});
}
- @Parameterized.Parameter
public boolean https;
- @Before
+ public void initHttps(boolean pHttps) throws ContainerExecutionException {
Review Comment:
Can this be made `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
