[ 
https://issues.apache.org/jira/browse/HADOOP-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931362#comment-17931362
 ] 

ASF GitHub Bot commented on HADOOP-19400:
-----------------------------------------

cnauroth commented on PR #7367:
URL: https://github.com/apache/hadoop/pull/7367#issuecomment-2689635000

   > > > Hello @anujmodi2021. Are you able to apply this patch and try a test 
run of `ITestAbfsFileSystemContractOpen`, `TestAdlContractOpenLive` and 
`ITestAzureNativeContractOpen`? I'd like to see if the new tests I'm adding 
pass on Azure. Thank you.
   > > 
   > > 
   > > @anujmodi2021 , gentle reminder on this request. Thank you!
   > 
   > Pardon me for the delay in response. Was not getting time to get to it. 
Will look into this today and get back to you soon.
   
   Thank you, totally understand it, and I appreciate the response!




> Expand specification and contract test coverage for InputStream reads.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-19400
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19400
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation, fs, test
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Major
>              Labels: pull-request-available
>
> This issue is a spin-off from HADOOP-19389, specifically [this code review 
> discussion|https://github.com/apache/hadoop/pull/7291#discussion_r1920495312].
>  We can enhance the FS specification and contract tests to cover expected 
> semantics of the {{InputStream}} single-byte and multi-byte read methods:
> * Multi-byte read should validate the arguments passed to it, according to 
> the pattern established in the JDK base {{InputStream}} class.
> * You should get the same bytes whether going through single-byte or 
> multi-byte read.
> * It is legal to mix calls to single-byte and multi-byte read, and this 
> should also yield the same bytes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to