cnauroth commented on PR #7449: URL: https://github.com/apache/hadoop/pull/7449#issuecomment-2692565629
> > +1 pending successful pre-submit. > > The changes make sense to me, but I'm curious to know why the JUnit 5 upgrade revealed this problem. I'd expect if there was an assertion on these test messages, then they would have failed in JUnit 4 too. > > @cnauroth Thank you very much for reviewing the code! I was able to reproduce the issue by running the unit tests with Junit4 locally, but Yetus did not detect it. For a long time, the YARN module used a mix of Junit4 and Junit5, and this mixed approach may have caused the maven-surefire-plugin to not filter out the problematic unit tests. However, once we fully upgraded to Junit5, the exceptions in the unit tests were exposed. That's very interesting! Do you think it indicates a Yetus bug? If so, please file a bug against that project. To be clear, I am still +1 on this patch, and thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
