[
https://issues.apache.org/jira/browse/HADOOP-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931995#comment-17931995
]
ASF GitHub Bot commented on HADOOP-19399:
-----------------------------------------
ahmarsuhail commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r1977672159
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSRegionEndpointInformation.java:
##########
@@ -0,0 +1,70 @@
+package org.apache.hadoop.fs.s3a.impl;
+
Review Comment:
@steveloughran starting to work on the CRT changes, wanted to get your
opinion on this. What do you think about doing some refactoring around this
region logic, so we have our own builder and container class for
`AWSRegionEndpointInformation` which all clients can get information out of.
Without this you have to duplicate the endpoint region logic for CRT and the
other clients since they use different builder classes. CRT uses
`S3CrtAsyncClientBuilder` which does not extend `S3BaseClientBuilder` and so
you can't use the existing method..
> S3A: Add support for CRT client
> -------------------------------
>
> Key: HADOOP-19399
> URL: https://issues.apache.org/jira/browse/HADOOP-19399
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.2
>
>
> * Allow ClientManager to initialise a CRT client
> * Should be optional, java async client to still be supported as default
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
