hfutatzhanghb commented on PR #7470: URL: https://github.com/apache/hadoop/pull/7470#issuecomment-2701009961
Sir, Thanks a lot for your valuable suggestions. Will use parameterized tests to implement this. ---- Replied Message ---- | From | ***@***.***> | | Date | 03/05/2025 21:44 | | To | ***@***.***> | | Cc | ***@***.***>***@***.***> | | Subject | Re: [apache/hadoop] HDFS-17751. [ARR] Add unit tests using asynchronous router rpc for all in org.apache.hadoop.hdfs.server.federation.router. (PR #7470) | @hfutatzhanghb Thank you for your contribution! However, I don't think adding unit tests for these packages is the best approach. If it's just a change in configuration, using parameterized tests would be a more appropriate choice, as it allows for maximum reuse of the existing test code. We can refer to the following documentation for more details: JUnit 5 Parameterized Tests. cc: @***@***.***@Hexiaoqiao — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> slfan1989 left a comment (apache/hadoop#7470) @hfutatzhanghb Thank you for your contribution! However, I don't think adding unit tests for these packages is the best approach. If it's just a change in configuration, using parameterized tests would be a more appropriate choice, as it allows for maximum reuse of the existing test code. We can refer to the following documentation for more details: JUnit 5 Parameterized Tests. cc: @***@***.***@Hexiaoqiao — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
