KeeProMise commented on code in PR #7422:
URL: https://github.com/apache/hadoop/pull/7422#discussion_r1991722010
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/async/TestRouterAsyncRPCMultipleDestinationMountTableResolver.java:
##########
@@ -84,6 +97,43 @@ public static void setUp() throws Exception {
rpcServer =routerContext.getRouter().getRpcServer();
}
+ @Test
+ public void testLocalResolverGetDatanodesSubcluster() throws IOException {
+ String testPath = "/testLocalResolverGetDatanodesSubcluster";
+ Path path = new Path(testPath);
+ Map<String, String> destMap = new HashMap<>();
+ destMap.put("ns0", testPath);
+ destMap.put("ns1", testPath);
+ nnFs0.mkdirs(path);
+ nnFs1.mkdirs(path);
+ MountTable addEntry =
+ MountTable.newInstance(testPath, destMap);
+ addEntry.setQuota(new RouterQuotaUsage.Builder().build());
+ addEntry.setDestOrder(DestinationOrder.LOCAL);
+ assertTrue(addMountTable(addEntry));
+
+ Map<String, String> datanodesSubcluster = null;
+ try {
+ MultipleDestinationMountTableResolver resolver =
+ (MultipleDestinationMountTableResolver)
routerContext.getRouter().getSubclusterResolver();
+ LocalResolver localResolver =
+ (LocalResolver) resolver.getOrderedResolver(DestinationOrder.LOCAL);
+ datanodesSubcluster = localResolver.getDatanodesSubcluster();
+ } catch (Exception e) {
+ LOG.info("Exception occurs when
testLocalResolverGetDatanodesSubcluster.", e);
+ } finally {
+ RouterClient client = routerContext.getAdminClient();
+ MountTableManager mountTableManager = client.getMountTableManager();
+ RemoveMountTableEntryRequest req2 =
+ RemoveMountTableEntryRequest.newInstance(testPath);
+ mountTableManager.removeMountTableEntry(req2);
+ nnFs0.delete(new Path(testPath), true);
+ nnFs1.delete(new Path(testPath), true);
+ }
+ assertNotNull(datanodesSubcluster);
+ assertTrue(!datanodesSubcluster.isEmpty());
Review Comment:
assertFalse(datanodesSubcluster.isEmpty())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
