[
https://issues.apache.org/jira/browse/HADOOP-19500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935388#comment-17935388
]
ASF GitHub Bot commented on HADOOP-19500:
-----------------------------------------
slfan1989 commented on code in PR #7503:
URL: https://github.com/apache/hadoop/pull/7503#discussion_r1994515014
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/invariants/TestMetricsInvariantChecker.java:
##########
@@ -30,8 +30,11 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
+import static org.junit.Assume.assumeNotNull;
Review Comment:
If we find that the relevant classes already use org.junit.jupiter, we can
use the JUnit 5 syntax.
> Skip tests that require JavaScript engine when it's not available
> -----------------------------------------------------------------
>
> Key: HADOOP-19500
> URL: https://issues.apache.org/jira/browse/HADOOP-19500
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Istvan Toth
> Priority: Major
> Labels: pull-request-available
>
> Some features require a JavaScript engine, which has been removed from JDK.
> Skip those tests if JavaScript is not available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
