stoty commented on code in PR #7503:
URL: https://github.com/apache/hadoop/pull/7503#discussion_r1995617830
##########
hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/TestSLSDagAMSimulator.java:
##########
@@ -62,6 +66,8 @@ public static Collection<Object[]> data() {
@Before
public void setup() {
+ //JavaScript engine has been removed from Java in Java 15.
+ assumeNotNull(new ScriptEngineManager().getEngineByName("JavaScript"));
Review Comment:
Thanks for the review @steveloughran .
A utility class wouldn't really work because some of the tests use JUnit 4
and others Junit 5.
I have refactored the changes, and pushed the SLS check into the superclass,
so that now there are only two assume instances, and a message is set.
##########
hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/TestSLSDagAMSimulator.java:
##########
@@ -28,9 +28,13 @@
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
+import static org.junit.Assume.assumeNotNull;
Review Comment:
Sure.
Is there an Eclipse code formatter definition somewhere I can use ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
