steveloughran commented on PR #7479: URL: https://github.com/apache/hadoop/pull/7479#issuecomment-2711242921
Output of `TestAWSV2SDK` indicates unshaded classes in bundle.jar including reactivestreams. The software/amazon are a false negative; test should be updated ``` 025-03-10 16:50:46,429 [JUnit-testShadedClasses] WARN sdk.TestAWSV2SDK (TestAWSV2SDK.java:testShadedClasses(68)) - Unshaded Classes Found :33 2025-03-10 16:50:46,430 [JUnit-testShadedClasses] WARN sdk.TestAWSV2SDK (TestAWSV2SDK.java:testShadedClasses(69)) - List of unshaded classes:[org/reactivestreams/FlowAdapters$FlowPublisherFromReactive.class, org/reactivestreams/FlowAdapters$FlowToReactiveProcessor.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscriber.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscription.class, org/reactivestreams/FlowAdapters$ReactivePublisherFromFlow.class, org/reactivestreams/FlowAdapters$ReactiveToFlowProcessor.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscriber.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscription.class, org/reactivestreams/FlowAdapters.class, org/reactivestreams/Processor.class, org/reactivestreams/Publisher.class, org/reactivestreams/Subscriber.class, org/reactivestreams/Subscription.class, software/amazon/eventstream/Checksums.class, software/amazon/eventstream/HeaderValue$IntegerValue.class, software/amazon/eventstream/Hea derValue$BooleanValue.class, software/amazon/eventstream/MessageDecoder.class, software/amazon/eventstream/HeaderValue$ByteValue.class, software/amazon/eventstream/Header.class, software/amazon/eventstream/HeaderValue$1.class, software/amazon/eventstream/HeaderType.class, software/amazon/eventstream/HeaderValue$TimestampValue.class, software/amazon/eventstream/HeaderValue$LongValue.class, software/amazon/eventstream/Utils.class, software/amazon/eventstream/HeaderValue$ShortValue.class, software/amazon/eventstream/MessageBuilder.class, software/amazon/eventstream/HeaderValue$StringValue.class, software/amazon/eventstream/HeaderValue$ByteArrayValue.class, software/amazon/eventstream/Prelude.class, software/amazon/eventstream/HeaderValue.class, software/amazon/eventstream/HeaderValue$UuidValue.class, software/amazon/eventstream/Message.class, META-INF/versions/9/module-info.class] ``` looking at the output of a branch-3.4 release they are not new; this not a regression, just unwelcome (and how did this get in?) ``` 2025-03-10 16:54:11,588 [JUnit-testShadedClasses] WARN sdk.TestAWSV2SDK (TestAWSV2SDK.java:testShadedClasses(68)) - Unshaded Classes Found :32 2025-03-10 16:54:11,588 [JUnit-testShadedClasses] WARN sdk.TestAWSV2SDK (TestAWSV2SDK.java:testShadedClasses(69)) - List of unshaded classes:[org/reactivestreams/FlowAdapters$FlowPublisherFromReactive.class, org/reactivestreams/FlowAdapters$FlowToReactiveProcessor.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscriber.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscription.class, org/reactivestreams/FlowAdapters$ReactivePublisherFromFlow.class, org/reactivestreams/FlowAdapters$ReactiveToFlowProcessor.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscriber.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscription.class, org/reactivestreams/FlowAdapters.class, org/reactivestreams/Processor.class, org/reactivestreams/Publisher.class, org/reactivestreams/Subscriber.class, org/reactivestreams/Subscription.class, software/amazon/eventstream/Checksums.class, software/amazon/eventstream/HeaderValue$IntegerValue.class, software/amazon/eventstream/Hea derValue$BooleanValue.class, software/amazon/eventstream/MessageDecoder.class, software/amazon/eventstream/HeaderValue$ByteValue.class, software/amazon/eventstream/Header.class, software/amazon/eventstream/HeaderValue$1.class, software/amazon/eventstream/HeaderType.class, software/amazon/eventstream/HeaderValue$TimestampValue.class, software/amazon/eventstream/HeaderValue$LongValue.class, software/amazon/eventstream/Utils.class, software/amazon/eventstream/HeaderValue$ShortValue.class, software/amazon/eventstream/MessageBuilder.class, software/amazon/eventstream/HeaderValue$StringValue.class, software/amazon/eventstream/HeaderValue$ByteArrayValue.class, software/amazon/eventstream/Prelude.class, software/amazon/eventstream/HeaderValue.class, software/amazon/eventstream/HeaderValue$UuidValue.class, software/amazon/eventstream/Message.class] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
