[
https://issues.apache.org/jira/browse/HADOOP-19384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936452#comment-17936452
]
ASF GitHub Bot commented on HADOOP-19384:
-----------------------------------------
steveloughran commented on PR #7284:
URL: https://github.com/apache/hadoop/pull/7284#issuecomment-2732736540
checkstyle is really, really close. Get that fixed ASAP and I will merge.
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:44:
/** Conf setting for credentials file path*/: First sentence should end with
a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:47:
/** Conf setting for profile name*/: First sentence should end with a period.
[JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:50:
/** Environment variable for credentials file path*/: First sentence should
end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:52:
/** Environment variable for profile name*/: First sentence should end with a
period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:64:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:70:
return
FileSystems.getDefault().getPath(SystemUtils.getUserHome().getPath(),".aws",
"credentials");: Line is longer than 100 characters (found 105). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:70:
return
FileSystems.getDefault().getPath(SystemUtils.getUserHome().getPath(),".aws",
"credentials");:82: ',' is not followed by whitespace. [WhitespaceAfter]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:71:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:84:
}:7: '}' at column 7 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:88:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:152:
try (FileWriter fileWriter = new FileWriter(tempFile); BufferedWriter
bufferedWriter = new BufferedWriter(fileWriter)) {: Line is longer than 100
characters (found 124). [LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:154:
+ "aws_access_key_id = defaultaccesskeyid\n": 'method call' child has
incorrect indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:155:
+ "aws_secret_access_key = defaultsecretkeyid\n");: 'method call' child
has incorrect indentation level 6, expected level should be 8. [Indentation]
```
> Add support for ProfileCredentialsProvider
> ------------------------------------------
>
> Key: HADOOP-19384
> URL: https://issues.apache.org/jira/browse/HADOOP-19384
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Venkatasubrahmanian Narayanan
> Assignee: Venkatasubrahmanian Narayanan
> Priority: Minor
> Labels: pull-request-available
>
> Hadoop currently doesn't support AWS' ProfileCredentialsProvider. A thin
> wrapper is sufficient to get it to work, since it just needs us to fetch the
> credentials file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
