[
https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273834#comment-13273834
]
Harsh J commented on HADOOP-8395:
---------------------------------
Thanks for checking Todd.
Yes, I manually tested the Text command with these two types of files (one used
a WritableComparable set, the other uses Writable sets), just to make sure the
subclass checks don't break anything.
As WritableComparable subclasses Writable, this does not break anything, only
relaxes the false requirement.
Committing to trunk shortly.
> Text shell command unnecessarily demands that a SequenceFile's key class be
> WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict
> subclass check for a sequence-file-header loaded key class to be a subclass
> of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence
> files with just plain writable keys, comparable is needed for sequence file's
> sorter alone, which not all of them use always), and hence its not reasonable
> for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not
> "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
