KeeProMise commented on code in PR #7466:
URL: https://github.com/apache/hadoop/pull/7466#discussion_r2003669481
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncClientProtocol.java:
##########
@@ -355,7 +355,6 @@ public boolean mkdirs(String src, FsPermission masked,
boolean createParent)
return rpcClient.invokeAll(locations, method);
}
- asyncComplete(false);
Review Comment:
Hi, @hfutatzhanghb I just took a look at this method, and I think it should
work fine without the modifications you suggested. First, set the
completeFuture in the thread pool variable to false. Next, if locations.size()
> 1, the completeFuture after execution will replace the thread variable. If
locations.size() <= 1, then since the initial value of completeFuture is set to
false, the subsequent asynchronous call code will be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
