[
https://issues.apache.org/jira/browse/HADOOP-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273999#comment-13273999
]
Hadoop QA commented on HADOOP-6801:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526633/HADOOP-6801.r5.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/991//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/991//console
This message is automatically generated.
> io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are
> still in CommonConfigurationKeysPublic.java and used in SequenceFile.java
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6801
> URL: https://issues.apache.org/jira/browse/HADOOP-6801
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Erik Steffl
> Assignee: Harsh J
> Priority: Minor
> Attachments: HADOOP-6801.r1.diff, HADOOP-6801.r2.diff,
> HADOOP-6801.r3.diff, HADOOP-6801.r4.diff, HADOOP-6801.r5.diff
>
>
> Following configuration keys in CommonConfigurationKeysPublic.java (former
> CommonConfigurationKeys.java):
> public static final String IO_SORT_MB_KEY = "io.sort.mb";
> public static final String IO_SORT_FACTOR_KEY = "io.sort.factor";
> are partially moved:
> - they were renamed to mapreduce.task.io.sort.mb and
> mapreduce.task.io.sort.factor respectively
> - they were moved to mapreduce project, documented in mapred-default.xml
> However:
> - they are still listed in CommonConfigurationKeysPublic.java as quoted
> above
> - strings "io.sort.mb" and "io.sort.factor" are used in SequenceFile.java
> in Hadoop Common project
> Not sure what the solution is, these constants should probably be removed
> from CommonConfigurationKeysPublic.java but I am not sure what's the best
> solution for SequenceFile.java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
