yangjiandan commented on code in PR #7527:
URL: https://github.com/apache/hadoop/pull/7527#discussion_r2013342166
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:
##########
@@ -586,17 +592,62 @@ InetAddress getByName(String hostname) throws
UnknownHostException {
return hostResolver.getByName(hostname);
}
}
-
+
interface HostResolver {
- InetAddress getByName(String host) throws UnknownHostException;
+ InetAddress getByName(String host) throws UnknownHostException;
+ }
+
+ static abstract class CacheableHostResolver implements HostResolver {
+ private volatile LoadingCache<String, InetAddress> cache;
+
+ CacheableHostResolver(int expiryIntervalSecs) {
+ if (expiryIntervalSecs > 0) {
+ cache = CacheBuilder.newBuilder()
+ .expireAfterWrite(expiryIntervalSecs, TimeUnit.SECONDS)
+ .build(new CacheLoader<String, InetAddress>() {
+ @Override
+ public InetAddress load(String key) throws Exception {
+ return resolve(key);
+ }
+ });
+ }
+ }
+ protected abstract InetAddress resolve(String host) throws
UnknownHostException;
+
+ @Override
+ public InetAddress getByName(String host) throws UnknownHostException {
+ if (cache != null) {
+ try {
+ return cache.get(host);
+ } catch (Exception e) {
+ Throwable cause = e.getCause();
+ if (cause instanceof UnknownHostException) {
+ throw (UnknownHostException) cause;
+ }
+ throw new UnknownHostException("Error resolving host " + host +
+ ": " + cause.getMessage());
Review Comment:
You are right!
I'll fix this potential error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
