pan3793 commented on PR #7535:
URL: https://github.com/apache/hadoop/pull/7535#issuecomment-2756918116
So this change intends to add a new checkstyle rule to forbid trailing
spaces of lines, this generally is a good idea, but after I apply it (I change
the severity to error to get the report) and check the current code base, there
are more than 40k places that violate this rule
```
<module name="RegexpSingleline">
<property name="format" value="\s+$"/>
<property name="severity" value="error"/>
</module>
```
```
mvn checkstyle:check | grep RegexpSingleline | wc -l
41890
```
If we add this rule, fixing those warnings will consume much time and
introduce unnecessary commit history, but without real benefits.
Given such a situation, I suggest NOT adding such a rule, and just keeping
things as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
