[ 
https://issues.apache.org/jira/browse/HADOOP-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938897#comment-17938897
 ] 

ASF GitHub Bot commented on HADOOP-19406:
-----------------------------------------

anmolanmol1234 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2016264998


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelegationSAS.java:
##########
@@ -91,14 +91,17 @@ public ITestAzureBlobFileSystemDelegationSAS() throws 
Exception {
   public void setup() throws Exception {
     isHNSEnabled = this.getConfiguration().getBoolean(
         TestConfigurationKeys.FS_AZURE_TEST_NAMESPACE_ENABLED_ACCOUNT, false);
-    Assume.assumeTrue(isHNSEnabled);
+    if(!isHNSEnabled){

Review Comment:
   Add more tests around user delegation SAS specific to FNS Blob and see it 
works correctly for all cases of implicit, explicit, root path, container path 





> ABFS: [FNS Over Blob] Support User Delegation SAS for FNS Blob
> --------------------------------------------------------------
>
>                 Key: HADOOP-19406
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19406
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.1
>            Reporter: Anmol Asrani
>            Assignee: Manika Joshi
>            Priority: Major
>              Labels: pull-request-available
>
> In ABFS Driver, user delegation SAS is currently only supported by 
> hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR 
> adds support for User Delegation SAS for non-HNS accounts over Blob endpoint 
> as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to