hfutatzhanghb commented on code in PR #7292:
URL: https://github.com/apache/hadoop/pull/7292#discussion_r2022357808
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/protocolPB/AsyncRpcProtocolPBUtil.java:
##########
@@ -87,6 +89,7 @@ public static <T, R> R asyncIpcClient(
// transfer thread local context to worker threads of executor.
ThreadLocalContext threadLocalContext = new ThreadLocalContext();
asyncCompleteWith(responseFuture.handleAsync((result, e) -> {
+ FederationRPCMetrics.ASYNC_RESPONDER_START_TIME.set(Time.monotonicNow());
Review Comment:
Hi, @KeeProMise . I think using ThreadLocalContext here will cause this
metrics not accurate. What's your opinion? Hope to receive from you! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
