[ https://issues.apache.org/jira/browse/HADOOP-19521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940209#comment-17940209 ]
ASF GitHub Bot commented on HADOOP-19521: ----------------------------------------- slfan1989 commented on PR #7557: URL: https://github.com/apache/hadoop/pull/7557#issuecomment-2771070896 > Hi @KeeProMise @slfan1989 , Could you please help review this simple modification when you have free time? Thanks. > More details please see the above description of this PR. From my perspective, this change is fine. However, I noticed that the previous PR was reviewed by KeeProMise, so it would be best to have @KeeProMise review this one as well. > Fix time unit mismatch in method updateDeferredMetrics > ------------------------------------------------------ > > Key: HADOOP-19521 > URL: https://issues.apache.org/jira/browse/HADOOP-19521 > Project: Hadoop Common > Issue Type: Bug > Components: metrics > Reporter: farmmamba > Assignee: farmmamba > Priority: Major > Labels: pull-request-available > > Fix time unit mismatch in method updateDeferredMetrics. > The time unit of passed param is nanos. But rpcmetrics's is mills. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org