[ 
https://issues.apache.org/jira/browse/HADOOP-19494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940258#comment-17940258
 ] 

ASF GitHub Bot commented on HADOOP-19494:
-----------------------------------------

bhattmanish98 commented on code in PR #7496:
URL: https://github.com/apache/hadoop/pull/7496#discussion_r2024103093


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemMkDir.java:
##########
@@ -167,4 +181,107 @@ public void testMkdirWithExistingFilename() throws 
Exception {
     intercept(FileAlreadyExistsException.class, () -> fs.mkdirs(new 
Path("/testFilePath")));
     intercept(FileAlreadyExistsException.class, () -> fs.mkdirs(new 
Path("/testFilePath/newDir")));
   }
+

Review Comment:
   The reason for adding these test cases here is we are performing mkdir calls 
with different cases of Hdi_isfolder. Therefore, the focus is on how mkdir 
behaves in these scenarios.
   But yes, it makes sense it is a metadata change so we can move it to other 
class if that seems more appropriate to you.





> ABFS: Fix Case Sensitivity Issue for hdi_isfolder metadata
> ----------------------------------------------------------
>
>                 Key: HADOOP-19494
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19494
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.5.0
>            Reporter: Manish Bhatt
>            Assignee: Manish Bhatt
>            Priority: Major
>              Labels: pull-request-available
>
> In the blob endpoint, we determine whether the path is a file, or a directory 
> based on the metadata attribute hdi_isfolder. When creating a directory, we 
> set hdi_isfolder to true. Currently, our method for checking if the path is a 
> directory involves a case-sensitive equality check. Consequently, if someone 
> configures a directory with Hdi_isfolder, the driver will not recognize that 
> path as a directory. We need to address this issue because, in the backend, 
> hdi_isfolder and Hdi_isfolder are considered the same metadata attribute. 
> Therefore, the solution involves modifying our equality check to be 
> case-insensitive, ensuring that the driver correctly identifies directories 
> regardless of case variations in the metadata attribute.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to