bhattmanish98 commented on code in PR #7564: URL: https://github.com/apache/hadoop/pull/7564#discussion_r2028390599
########## hadoop-tools/hadoop-azure/dev-support/testrun-scripts/config_support.sh: ########## @@ -0,0 +1,157 @@ +#!/usr/bin/env bash + +set -eo pipefail + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FILE=$1 + +if [ ! -f "$FILE" ]; then + echo "Error: File '$FILE' not found. Exiting...." + exit 1 +fi + +if [[ "$1" != *.xml ]]; then Review Comment: Since we have already assigned $1 to FILE, it would be better to use $FILE. `if [[ "$FILE" != *.xml ]]; then` ########## hadoop-tools/hadoop-azure/dev-support/testrun-scripts/config_support.sh: ########## @@ -0,0 +1,157 @@ +#!/usr/bin/env bash Review Comment: Better to keep file name in camel case or all characters in small case just like we have for other test scripts. ########## hadoop-tools/hadoop-azure/dev-support/testrun-scripts/config_support.sh: ########## @@ -0,0 +1,157 @@ +#!/usr/bin/env bash + +set -eo pipefail + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FILE=$1 + +if [ ! -f "$FILE" ]; then + echo "Error: File '$FILE' not found. Exiting...." + exit 1 +fi + +if [[ "$1" != *.xml ]]; then + echo "The file provided is not an XML file. Exiting...." + exit 1 +fi + +OUTPUT_FILE="abfs-converted-config.xml" +cp "$FILE" "$OUTPUT_FILE" + +contactTeamMsg="For any queries or support, kindly reach out to us at 'aska...@microsoft.com'." +endpoint=".dfs." +printf "Select 'HNS' if you're migrating to ABFS driver for Hierarchical Namespace enabled account, + or 'Non-HNS' if you're migrating to ABFS driver for Non-Hierarchical Namespace (FNS) account. \n" +printf "WARNING: Please ensure the correct option is chosen as it will affect the configuration changes made to the file. \n" +printf "If you are unsure, follow the instructions below to check from Azure Portal: \n" +printf "* Go to the Azure Portal and navigate to your storage account. \n" +printf "* In the left-hand menu, select 'Overview' section and look for 'Properties'. \n" +printf "* Under 'Blob service', check if 'Hierarchical namespace' is enabled or disabled. \n" +echo "$contactTeamMsg" +select namespaceType in "HNS" "NonHNS" +do + case $namespaceType in + HNS) + xmlstarlet ed -L -i '//configuration/property[1]' -t elem -n property -v '' \ + -s '//configuration/property[1]' -t elem -n name -v 'fs.azure.account.hns.enabled' \ + -s '//configuration/property[1]' -t elem -n value -v 'true' "$OUTPUT_FILE" + break; + ;; + NonHNS) + endpoint=".blob." + break; + ;; + *) + echo "Invalid selection. Please try again. Exiting..." + exit 1; + ;; + esac +done + +# Mapping for renaming configurations +declare -A rename_configs_map=( Review Comment: variable naming should be as per java (use camel casing instead of snake casing) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
