[ 
https://issues.apache.org/jira/browse/HADOOP-19525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940058#comment-17940058
 ] 

ASF GitHub Bot commented on HADOOP-19525:
-----------------------------------------

YanivKunda opened a new pull request, #7569:
URL: https://github.com/apache/hadoop/pull/7569

   ### Description of PR
   
   Closes HADOOP-19525
   
   ### How was this patch tested?
   
   Ran all existing tests.
   
   ### For code changes:
   
   - [V] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Use java.time.Clock instead of org.apache.hadoop.util.Clock
> -----------------------------------------------------------
>
>                 Key: HADOOP-19525
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19525
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: hadoop-common, mapreduce, yarn
>            Reporter: Yaniv Kunda
>            Assignee: Yaniv Kunda
>            Priority: Major
>
> Hadoop's {{Clock}} interface was recently moved from 
> {{org.apache.hadoop.yarn.util}} (in hadoop-yarn) to 
> {{org.apache.hadoop.util}} (in hadoop-common) as part of YARN-11765.
> I propose to seize the opportunity of this being targeted done for 3.5.0 to 
> modernize it usage:
> # Deprecate {{org.apache.hadoop.util.Clock}}
> # Replace all of its usages with {{java.time.Clock}}
> # Replace existing usages of its simple implementations, e.g. 
> {{SystemClock}}/{{UTCClock}} with standard {{java.time.Clock}} subclasses, 
> e.g. {{Clock.systemUTC()}}
> # Re-implement other implementations, e.g. 
> {{MonotonicClock}}/{{ControllerClock}}, as {{java.time.Clock}} subclasses.
> The standard {{java.time.Clock}} has a richer API supports modern 
> {{java.time}} classes such as {{Instant}} and {{ZoneId}}, and migration would 
> be straightforward:
> Just changing {{org.apache.hadoop.util.Clock.getTime()}} to 
> {{java.time.Clock.millis()}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to