pan3793 commented on code in PR #7570: URL: https://github.com/apache/hadoop/pull/7570#discussion_r2035327543
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanFollower.java: ########## @@ -17,10 +17,10 @@ *******************************************************************************/ package org.apache.hadoop.yarn.server.resourcemanager.reservation; +import java.time.Clock; import java.util.Collection; import org.apache.hadoop.yarn.server.resourcemanager.scheduler.ResourceScheduler; -import org.apache.hadoop.util.Clock; Review Comment: I just took a closer look, `org.apache.hadoop.util.Clock` was actually exposed to the public API, such changes bring unnecessary compatibility issues. Given Hadoop is already in a post-mature state, I would avoid such changes as much as possible. Back to the original intention of the changes, how about leaving the `org.apache.hadoop.yarn.util.Clock` as-is (which means reverting YARN-11765), and introducing a new Clock implementation in the Common module based on the JDK `Clock` for new use cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
