[
https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278664#comment-13278664
]
Hadoop QA commented on HADOOP-7818:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528017/HADOOP-7818-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1006//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1006//console
This message is automatically generated.
> DiskChecker#checkDir should fail if the directory is not executable
> -------------------------------------------------------------------
>
> Key: HADOOP-7818
> URL: https://issues.apache.org/jira/browse/HADOOP-7818
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: HADOOP-7818-1.patch, HADOOP-7818.patch
>
>
> DiskChecker#checkDir fails if a directory can't be created, read, or written
> but does not fail if the directory exists and is not executable. This causes
> subsequent code to think the directory is OK but later fail due to an
> inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir
> fails if the directory is not executable. Looking at the uses, this should be
> fine, I think it was ignored because checkDir is often used to create
> directories and it creates executable directories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
