TaoYang526 commented on code in PR #7589:
URL: https://github.com/apache/hadoop/pull/7589#discussion_r2041285703
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractLeafQueue.java:
##########
@@ -1302,19 +1362,26 @@ public CSAssignment assignContainers(Resource
clusterResource,
ActivitiesLogger.QUEUE.recordQueueActivity(activitiesManager, node,
parent.getQueuePath(), getQueuePath(),
ActivityState.ACCEPTED, ActivityDiagnosticConstant.EMPTY);
+ // Reset missed scheduling opportunities after successfully allocating
+ // resources for the application.
+ application.resetAppMissedSchedulingOpportunities();
return assignment;
} else if (assignment.getSkippedType()
== CSAssignment.SkippedType.OTHER) {
ActivitiesLogger.APP.finishSkippedAppAllocationRecording(
activitiesManager, application.getApplicationId(),
ActivityState.SKIPPED, ActivityDiagnosticConstant.EMPTY);
application.updateNodeInfoForAMDiagnostics(node);
+ // Add missed scheduling opportunities for the application
+ application.addAppMissedSchedulingOpportunities();
} else if (assignment.getSkippedType()
== CSAssignment.SkippedType.QUEUE_LIMIT) {
ActivitiesLogger.QUEUE.recordQueueActivity(activitiesManager, node,
parent.getQueuePath(), getQueuePath(), ActivityState.REJECTED,
() -> ActivityDiagnosticConstant.QUEUE_DO_NOT_HAVE_ENOUGH_HEADROOM
+ " from " + application.getApplicationId());
+ // Add missed scheduling opportunities for the application
+ application.addAppMissedSchedulingOpportunities();
return assignment;
} else{
// If we don't allocate anything, and it is not skipped by application,
Review Comment:
Thanks @zeekling for the review.
This check was intended to quickly skip redundant checks for every node when
reached the queue limit, which is already resolved in YARN-11798. So it's not
necessary for the latest code, I'll remove this line later. Thanks for
reminding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
