steveloughran commented on code in PR #7616:
URL: https://github.com/apache/hadoop/pull/7616#discussion_r2045532243
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/StreamStatisticNames.java:
##########
@@ -104,6 +104,13 @@ public final class StreamStatisticNames {
*/
public static final String STREAM_READ_ANALYTICS_OPENED =
"stream_read_analytics_opened";
+ /**
+ * Total count of times object stream factory was closed
Review Comment:
nit, add .
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java:
##########
@@ -95,6 +96,13 @@ public StreamFactoryRequirements factoryRequirements() {
StreamFactoryRequirements.Requirements.ExpectUnauditedGetRequests);
}
+ @Override
+ protected void serviceStop() throws Exception {
+ super.serviceStop();
+ this.s3SeekableInputStreamFactory.close();
Review Comment:
do these before calling the superclass. I think that's actually a no-op, but
good to unwind in order
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/ObjectInputStreamFactory.java:
##########
@@ -20,6 +20,7 @@
import java.io.IOException;
+import org.apache.hadoop.fs.s3a.Statistic;
Review Comment:
ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
