BsoBird commented on code in PR #7602: URL: https://github.com/apache/hadoop/pull/7602#discussion_r2046629911
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/GlobalStateIdContext.java: ########## @@ -156,9 +157,11 @@ public long receiveRequestState(RpcRequestHeaderProto header, ESTIMATED_TRANSACTIONS_PER_SECOND * TimeUnit.MILLISECONDS.toSeconds(clientWaitTime) * ESTIMATED_SERVER_TIME_MULTIPLIER) { - throw new RetriableException( - "Observer Node is too far behind: serverStateId = " - + serverStateId + " clientStateId = " + clientStateId); + String message = "Retrying to Active NameNode, Observer Node is too" + + " far behind: serverStateId = " + serverStateId + + " clientStateId = " + clientStateId; + FSNamesystem.LOG.warn(message); Review Comment: Since we have thrown an exception, is it necessary to log another message here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org