[
https://issues.apache.org/jira/browse/HADOOP-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins reassigned HADOOP-7818:
-----------------------------------
Assignee: madhukara phatak (was: Eli Collins)
javadoc warnings are unrelated.
+1
Nit: the indenting on the new line is off, see the surrounding code, and the
new test needs a newline before it, I'll fix these before committing, for
future patches please indent according to the convention.
Thanks for contributing!
> DiskChecker#checkDir should fail if the directory is not executable
> -------------------------------------------------------------------
>
> Key: HADOOP-7818
> URL: https://issues.apache.org/jira/browse/HADOOP-7818
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
> Reporter: Eli Collins
> Assignee: madhukara phatak
> Priority: Minor
> Attachments: HADOOP-7818-1.patch, HADOOP-7818.patch
>
>
> DiskChecker#checkDir fails if a directory can't be created, read, or written
> but does not fail if the directory exists and is not executable. This causes
> subsequent code to think the directory is OK but later fail due to an
> inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir
> fails if the directory is not executable. Looking at the uses, this should be
> fine, I think it was ignored because checkDir is often used to create
> directories and it creates executable directories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira