[
https://issues.apache.org/jira/browse/HADOOP-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945588#comment-17945588
]
ASF GitHub Bot commented on HADOOP-19406:
-----------------------------------------
manika137 commented on code in PR #7523:
URL: https://github.com/apache/hadoop/pull/7523#discussion_r2050042305
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/DelegationSASGenerator.java:
##########
@@ -68,18 +70,25 @@ public String getDelegationSAS(String accountName, String
containerName, String
case SASTokenProvider.DELETE_RECURSIVE_OPERATION:
sp = "d";
sr = "d";
- sdd = Integer.toString(StringUtils.countMatches(path, "/"));
+ sdd = path.equals("/")? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
Review Comment:
Converted it to path.equals(ROOT_PATH)? "0":
Integer.toString(StringUtils.countMatches(path, "/"));
Did not change the last "/" part for readability purpose
##########
hadoop-tools/hadoop-azure/src/site/markdown/index.md:
##########
@@ -651,13 +651,16 @@ To know more about how SAS Authentication works refer to
[Grant limited access to Azure Storage resources using shared access
signatures
(SAS)](https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview)
There are three types of SAS supported by Azure Storage:
> ABFS: [FNS Over Blob] Support User Delegation SAS for FNS Blob
> --------------------------------------------------------------
>
> Key: HADOOP-19406
> URL: https://issues.apache.org/jira/browse/HADOOP-19406
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> In ABFS Driver, user delegation SAS is currently only supported by
> hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR
> adds support for User Delegation SAS for non-HNS accounts over Blob endpoint
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
