slfan1989 commented on PR #7626: URL: https://github.com/apache/hadoop/pull/7626#issuecomment-2822759965
> +1 the change looks good. > > Just a question: Could we remove the junit 4 dependency? > > Sugguestions for the future PRs: > > * The PR is very large -- the patch files is > 200KB. It took me a few days to review it. I would suggest splitting it into 4 or more PRs, 50KB each. It will improve the turn around time. > * For such a large PR, please don't change indentations. It becomes a never ending reviewing. > > I do appreciate your efforts! @szetszwo Thank you very much for reviewing the code and providing valuable feedback! We greatly appreciate your efforts. Currently, the HDFS project contains over 790 unit tests, and we aim to find a reasonable balance between the size of the PRs and what is acceptable for reviewers. To control the number of PRs, we are currently bundling them in batches of 50 classes, which means we will need to submit at least 15 PRs. If we don’t do this, it could result in more PRs related to the HDFS upgrade, and for users who require backporting, the large number of PRs could be less friendly. This process is indeed challenging, and we don't want the JUnit 4 upgrade to become too fragmented. Your help is especially important for the HDFS module. We may need to wait until the entire HDFS module is upgraded before we can remove the JUnit 4 dependency. cc: @zhtttylz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
