[
https://issues.apache.org/jira/browse/HADOOP-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947180#comment-17947180
]
ASF GitHub Bot commented on HADOOP-19417:
-----------------------------------------
slfan1989 commented on PR #7636:
URL: https://github.com/apache/hadoop/pull/7636#issuecomment-2829170703
> LGTM. +1. Thanks @slfan1989 .
> Some nit checkstyle issues but I think it is OK to improve it later. Such
as miss blank space before and after plus
[here](https://github.com/apache/hadoop/pull/7636/files#diff-c6354dc57fc89a71b0f76b063342c6af6fcc76bc43127b3d04527cbca9db797eR218).
Some line should be more readable to keep the original format, such as
[here](https://github.com/apache/hadoop/pull/7636/files#diff-04586ef9263f660fb6d67a11f2fbb50ae5ed5306b6167656f61db3ea20b97900R108).
@Hexiaoqiao @cnauroth @jojochuang Thank you very much for reviewing this PR!
I will improve this PR based on your suggestions.
> Upgrade JUnit from 4 to 5 in hadoop-minikdc.
> --------------------------------------------
>
> Key: HADOOP-19417
> URL: https://issues.apache.org/jira/browse/HADOOP-19417
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
