[ 
https://issues.apache.org/jira/browse/HADOOP-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948522#comment-17948522
 ] 

ASF GitHub Bot commented on HADOOP-19557:
-----------------------------------------

steveloughran commented on PR #7663:
URL: https://github.com/apache/hadoop/pull/7663#issuecomment-2842483012

   tested s3 london with analytics input stream. all good, one expected and 
unrelated test failure 
(AbstractContractOpenTest.testInputStreamReadNegativePosition)




> S3A: S3ABlockOutputStream to never log/reject hflush(): calls
> -------------------------------------------------------------
>
>                 Key: HADOOP-19557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19557
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Critical
>              Labels: pull-request-available
>
> Parquet's GH-3204 patch uses hflush() just before close()
> this is needless and hurts write performance on hdfs.
> For s3A it will trigger a warning long (Syncable is not supported) or an 
> actual failure if
> fs.s3a.downgrade.syncable.exceptions is false
> proposed: hflush to log at debug -only log/reject on hsync, which is the real 
> place where semantics cannot be met



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to