[ 
https://issues.apache.org/jira/browse/HADOOP-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280573#comment-13280573
 ] 

Daryn Sharp commented on HADOOP-8414:
-------------------------------------

Odd, for my known knowledge of quirks, does 
{{InetAddress.getByName(null).getHostName()}} and 
{{InetAddress.getByName(null).getCanonicalHostName()}} also return just 
127.0.0.1?  This is a bit dismaying, because the tests are trying to verify 
that the output contains the _exact path(s)_ as given on the cmdline.  I spent 
quite a bit of time ensuring one can parse the output for a given path.  
Allowing either localhost or 127.0.0.1 to match means the tests won't catch if 
something mangles the host for non-windows platforms.  I'm not sure how to deal 
with that... :(

The majority of the code mangling the authority into another uri, that you had 
to touch, is basically trying to convert {{scheme-host:port}} into 
{{scheme://host:port}}.  Instead of all the null and -1 checks to rebuild the 
uri, it seems it would be simpler to just use {{replaceFirst}}.  It also avoids 
introducing more ipv6 incompatibilities caused by a naive split on ":".
                
> Address problems related to localhost resolving to 127.0.0.1 on Windows
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8414
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8414
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, test
>    Affects Versions: 1.0.0
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HADOOP-8414-branch-1-win.patch
>
>
> Localhost resolves to 127.0.0.1 on Windows and that causes the following 
> tests to fail:
>  - TestHarFileSystem
>  - TestCLI
>  - TestSaslRPC
> This Jira tracks fixing these tests and other possible places that have 
> similar issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to