[ 
https://issues.apache.org/jira/browse/HADOOP-19426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949435#comment-17949435
 ] 

ASF GitHub Bot commented on HADOOP-19426:
-----------------------------------------

slfan1989 commented on code in PR #7652:
URL: https://github.com/apache/hadoop/pull/7652#discussion_r2073461156


##########
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlInternalCreateNonRecursive.java:
##########
@@ -23,25 +23,23 @@
 import org.apache.hadoop.fs.FileAlreadyExistsException;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.fs.adl.common.Parallelized;
 import org.apache.hadoop.fs.permission.FsPermission;
-import org.junit.Assert;
-import org.junit.Assume;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.UUID;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
+
 /**
  * Test createNonRecursive API.
  */
-@RunWith(Parallelized.class)

Review Comment:
   Thank you for your question! We need to remove `Parallelized.class`. 
   
   When upgrading from JUnit 4 to JUnit 5, `ParameterizedTest` replaces the 
`Parameterized` runner in JUnit 4. JUnit 5 uses 
`org.junit.jupiter.params.ParameterizedTest` along with annotations like 
`@ValueSource`, `@EnumSource`, or `@CsvSource` to provide support for 
parameterized tests. In JUnit 4, parameterized tests need to be declared using 
`@RunWith(Parameterized.class)` and set up with a data source.
   
   We can refer to the chapter 
(https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests)](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests).
   
   





> Upgrade JUnit from 4 to 5 in hadoop-azure-datalake.
> ---------------------------------------------------
>
>                 Key: HADOOP-19426
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19426
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, test
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to