[
https://issues.apache.org/jira/browse/HADOOP-18562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950537#comment-17950537
]
ASF GitHub Bot commented on HADOOP-18562:
-----------------------------------------
ahmarsuhail commented on code in PR #7379:
URL: https://github.com/apache/hadoop/pull/7379#discussion_r2081836752
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -947,6 +947,32 @@ The switch to turn S3A auditing on or off.
</property>
```
+
+### Configuring Custom Headers for AWS Service Clients
+
+The S3A client allows users to set custom headers for specific AWS services,
such as S3 and STS.
Review Comment:
nit: you can just rephrase this to:
"You can set custom headers for S3 and STS requests. These headers are set
on client level, and will be sent for all requests made to these services."
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##########
@@ -1339,6 +1340,37 @@ private Constants() {
public static final String AWS_SERVICE_IDENTIFIER_DDB = "DDB";
public static final String AWS_SERVICE_IDENTIFIER_STS = "STS";
+ /** Prefix for S3A client-specific properties.
+ * value: {@value}
+ */
+ public static final String FS_S3A_CLIENT_PREFIX = "fs.s3a.client.";
+
+ /** Custom headers postfix.
+ * value: {@value}
+ */
+ public static final String CUSTOM_HEADERS_POSTFIX = ".custom.headers";
+
+ /**
Review Comment:
look at steve's comment on the other PR and fix:
https://github.com/apache/hadoop/pull/6550/files#r1812732876
> S3A: support custom S3 and STS headers
> --------------------------------------
>
> Key: HADOOP-18562
> URL: https://issues.apache.org/jira/browse/HADOOP-18562
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Daniel Carl Jones
> Assignee: Prerak Pradhan
> Priority: Minor
> Labels: pull-request-available
>
> Some users have the use case where for a particular S3A filesystem, they
> would like to set one or more headers to a static value.
> We might imagine a set of configurations properties with a common prefix,
> where the suffix determines the header name and the value of the property
> determines the value of the header.
> Per-filesystem headers can be set using the per-bucket configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
