[ 
https://issues.apache.org/jira/browse/HADOOP-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281476#comment-13281476
 ] 

Harsh J commented on HADOOP-8415:
---------------------------------

Hey [~janlugt],

Sorry, should've been more precise. The test is called simply TestConfiguration 
(You'll find many tests for classes via Test[ClassName] in Hadoop, as a general 
pattern). You should see test methods in there for Float methods which you can 
simply ape for Double then.

Regarding the trunk patch, the same may apply but your patch's root ought to be 
the root trunk directory. Here it seems to be hadoop-common as root. This is 
required to be able to run the QA Bot for patch validation across the project 
automatically. Its not a big deal so long as you can ensure your patch applies 
cleanly to trunk, wherever its based. I can rebase it to the right directory 
for you afterwards.
                
> getDouble() and setDouble() in org.apache.hadoop.conf.Configuration
> -------------------------------------------------------------------
>
>                 Key: HADOOP-8415
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8415
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 1.0.2
>            Reporter: Jan van der Lugt
>            Priority: Minor
>         Attachments: HADOOP-8415.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> In the org.apache.hadoop.conf.Configuration class, methods exist to set 
> Integers, Longs, Booleans, Floats and Strings, but methods for Doubles are 
> absent. Are they not there for a reason or should they be added? In the 
> latter case, the attached patch contains the missing functions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to