[
https://issues.apache.org/jira/browse/HADOOP-19575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955163#comment-17955163
]
ASF GitHub Bot commented on HADOOP-19575:
-----------------------------------------
manika137 commented on code in PR #7713:
URL: https://github.com/apache/hadoop/pull/7713#discussion_r2115531825
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -355,6 +356,44 @@ public void verifyUserAgentClusterType() throws Exception {
.contains(DEFAULT_VALUE_UNKNOWN);
}
+ @Test
+ // Test to verify the unique identifier in user agent string for FNS-Blob
accounts
+ public void verifyUserAgentForFNSBlob() throws Exception {
+ Assume.assumeTrue(JDK_HTTP_URL_CONNECTION == httpOperationType);
+ assumeHnsDisabled();
+ Assume.assumeTrue(getAbfsServiceType() == AbfsServiceType.BLOB);
+ final AzureBlobFileSystem fs = getFileSystem(getRawConfiguration());
+ final AbfsConfiguration configuration = fs.getAbfsStore()
+ .getAbfsConfiguration();
+
+ String userAgentStr = getUserAgentString(configuration, false);
+ verifyBasicInfo(userAgentStr);
+ Assertions.assertThat(userAgentStr)
+ .describedAs(
+ "User-Agent string for FNS accounts on Blob endpoint should
contain "
+ + FNS_BLOB_USER_AGENT_IDENTIFIER)
+ .contains(FNS_BLOB_USER_AGENT_IDENTIFIER);
+ }
+
+ @Test
+ // Test to verify that the user agent string for non-FNS-Blob accounts
+ // does not contain the FNS identifier.
+ public void verifyUserAgentForDFS() throws Exception {
Review Comment:
For both HNS-DFS and FNS-DFS we would want to check that the string isnt
added right
> ABFS: [FNSOverBlob] Add Distinct String In User Agent to Get Telemetry for
> FNS-Blob
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-19575
> URL: https://issues.apache.org/jira/browse/HADOOP-19575
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0, 3.4.1
> Reporter: Manika Joshi
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> Add a unique identifier in FNS-Blob user agent to get their usage through
> telemetry
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
