steveloughran commented on code in PR #7802:
URL: https://github.com/apache/hadoop/pull/7802#discussion_r2205569618


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/AWSCredentialProviderList.java:
##########
@@ -197,7 +197,17 @@ public AwsCredentials resolveCredentials() {
       } catch (SdkException e) {
         lastException = e;
         LOG.debug("No credentials provided by {}: {}",
-            provider, e.toString(), e);
+            provider, e);

Review Comment:
   seems good



##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/CredentialProviderListFactory.java:
##########
@@ -184,6 +198,8 @@ private static Map<String, String> 
initCredentialProvidersMap() {
         EC2_IAM_CREDENTIALS_V2);
     v1v2CredentialProviderMap.put(ENVIRONMENT_CREDENTIALS_V1,
         ENVIRONMENT_CREDENTIALS_V2);
+    v1v2CredentialProviderMap.put(WEB_IDENTITY_CREDENTIALS_V1,

Review Comment:
   no need to care about v1 to v2 migration; this wasn't something in use. if 
it was, we'd have had complaints about



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to