[ 
https://issues.apache.org/jira/browse/HADOOP-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283761#comment-13283761
 ] 

Hadoop QA commented on HADOOP-8278:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12529778/HADOOP-8278.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified test 
files.

    -1 javac.  The applied patch generated 1999 javac compiler warnings (more 
than the trunk's current 1996 warnings).

    -1 javadoc.  The javadoc tool appears to have generated 19 warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests in 
hadoop-common-project/hadoop-annotations hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs 
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal 
hadoop-mapreduce-project/hadoop-mapreduce-examples:

                  org.apache.hadoop.http.TestHttpServer
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1038//testReport/
Javac warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1038//artifact/trunk/trunk/patchprocess/diffJavacWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1038//console

This message is automatically generated.
                
> Make sure components declare correct set of dependencies
> --------------------------------------------------------
>
>                 Key: HADOOP-8278
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8278
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tom White
>         Attachments: HADOOP-8278.patch, HADOOP-8278.patch
>
>
> As mentioned by Scott Carey in 
> https://issues.apache.org/jira/browse/MAPREDUCE-3378?focusedCommentId=13173437&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13173437,
>  we need to make sure that components are declaring the correct set of 
> dependencies. In current trunk there are errors of omission and commission 
> (as reported by 'mvn dependency:analyze'):
> * "Used undeclared dependencies" - these are dependencies that are being met 
> transitively. They should be added explicitly as "compile" or "provided" 
> scope.
> * "Unused declared dependencies" - these are dependencies that are not needed 
> for compilation, although they may be needed at runtime. They certainly 
> should not be "compile" scope - they should either be removed or marked as 
> "runtime" or "test" scope.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to