[ 
https://issues.apache.org/jira/browse/HADOOP-19634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009245#comment-18009245
 ] 

ASF GitHub Bot commented on HADOOP-19634:
-----------------------------------------

pjfanning opened a new pull request, #7821:
URL: https://github.com/apache/hadoop/pull/7821

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   See https://issues.apache.org/jira/browse/HADOOP-19634
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> acknowledge Guava license on LimitInputStream
> ---------------------------------------------
>
>                 Key: HADOOP-19634
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19634
>             Project: Hadoop Common
>          Issue Type: Task
>            Reporter: PJ Fanning
>            Priority: Major
>
> When ASF projects copy 3rd party code into their code bases, they are meant 
> to:
> * check the orginal license is Category A - 
> https://www.apache.org/legal/resolved.html
> * keep the original source code headers
> * add something to their LICENSE that mentions the source file and what 
> license is on it
> * if the 3rd party project is Apache licensed but has a NOTICE file, we need 
> to copy copy its contents to our NOTICE
> * these requirements are only negated if the original code is submitted to 
> the ASF project by the code's copyright holder (the individual or company 
> that wrote the original code).
> * Hadoop copy 
> https://github.com/apache/hadoop/blob/c357e435fd691b4c184b82325bef6d7c65e5f32b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LimitInputStream.java#L39
> * Original code has a Guava copyright that we probably need to keep 
> https://github.com/google/guava/blob/master/guava/src/com/google/common/io/ByteStreams.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to