[ 
https://issues.apache.org/jira/browse/HADOOP-19608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009508#comment-18009508
 ] 

ASF GitHub Bot commented on HADOOP-19608:
-----------------------------------------

steveloughran commented on PR #7785:
URL: https://github.com/apache/hadoop/pull/7785#issuecomment-3112764318

   @slfan1989 thanks, should be good soon, though miniyarn clusters aren't 
playing (think it's unrelated).
   
   And I know a lot more about JUnit 5, even though I think the team don't 
value developer's existing codebase *or knowledge* enough. Most unhappy about
   - changed ordering of assertEquals with message.
   - the way that @Test, @BeforeEach, @AfterEach aren't inherited any more. 
Junit 1 only had `setUp()` as the setup method, and so those of us who started 
coding that way have expectations no longer being met.
   
   
   At least our adoption of AssertJ was prescient. 




> Upgrade to Junit 5.13.3
> -----------------------
>
>                 Key: HADOOP-19608
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19608
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, test
>    Affects Versions: 3.5.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> Upgrade to JUnit 5.13.3 so that Parameterized test classes work again.
> Needs corresponding updates in surefire



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to