[ 
https://issues.apache.org/jira/browse/HADOOP-19636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18009884#comment-18009884
 ] 

ASF GitHub Bot commented on HADOOP-19636:
-----------------------------------------

Hexiaoqiao commented on code in PR #7822:
URL: https://github.com/apache/hadoop/pull/7822#discussion_r2230528916


##########
dev-support/docker/Dockerfile_centos_8:
##########
@@ -1,118 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM centos:8

Review Comment:
   My point is that we should remove some dependencies which are EOL, just like 
some other module. Back to here , CentOS 8 has reached its EOL and the packages 
re no longer available on mirror.centos.org 
site.(https://www.centos.org/centos-linux-eol/), So +1 to Shilun's comments 
from my side. cc @pan3793 What do you think about. Thanks.



##########
dev-support/Jenkinsfile:
##########
@@ -113,144 +113,6 @@ pipeline {
             }
         }
 
-        // This is an optional stage which runs only when there's a change in
-        // C++/C++ build/platform.
-        // This stage serves as a means of cross platform validation, which is
-        // really needed to ensure that any C++ related/platform change doesn't
-        // break the Hadoop build on Centos 7.
-        stage ('precommit-run Centos 7') {

Review Comment:
   +1





> [JDK17] Remove EOL OS Support and Clean Up Dockerfile.
> ------------------------------------------------------
>
>                 Key: HADOOP-19636
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19636
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> Removed build support for the following EOL (End-of-Life) operating system 
> versions (e.g., CentOS 7, Debian 9, etc.).
> Cleaned up redundant code and dependency configurations in the Dockerfile 
> related to these operating systems.
> Optimized the build logic to ensure that currently supported OS versions 
> build successfully.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to